ApiCallMonitor::getProcessMonitor getter + start and end method adjus…

…tement

CHANGELOG.md

@@ -1,5 +1,16 @@
 CHANGELOG for 1.x
 ===================
+## v1.4.2 - (2024-06-05)
+### Added
+- `ApiCallMonitor::getProcessMonitor` getter to access the ProcessMonitor instance through it
+
+### Changed
+- `ApiCallMonitor::start` add **$flush** param to match `ProcessMonitor::start` definition
+- `ApiCallMonitor::end` use Symfony Response const instead of hard coded value for the isSuccess check, also expand the range to >= 100 and < 400
+
+### Fixed
+- `GroupConcat` remove @phpstan-ignore-line false positive 
+
 ## v1.4.1 - (2024-05-29)
 ### Fixed
 - `DateUtils::millisecondsToString` int type cast when calling **secondsToString** to fix the deprecated: Implicit conversion from float

src/Monitoring/ApiCallMonitor.php

@@ -3,8 +3,8 @@
 namespace Smart\CoreBundle\Monitoring;
 
 use Smart\CoreBundle\Entity\ApiCallInterface;
-use Smart\CoreBundle\Entity\ProcessInterface;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 /**
  * @author Mathieu Ducrot <[email protected]>
@@ -15,9 +15,9 @@ public function __construct(private readonly ProcessMonitor $processMonitor)
     {
     }
 
-    public function start(ApiCallInterface $apiCall, Request $request): ApiCallInterface
+    public function start(ApiCallInterface $apiCall, Request $request, bool $flush = false): ApiCallInterface
     {
-        $this->processMonitor->start($apiCall);
+        $this->processMonitor->start($apiCall, $flush);
         $apiCall->setMethod($request->getMethod());
         $apiCall->setRouteUrl($request->getUri());
         $apiCall->setType($request->attributes->get('_route'));
@@ -29,6 +29,11 @@ public function start(ApiCallInterface $apiCall, Request $request): ApiCallInter
     public function end(ApiCallInterface $apiCall, int $statusCode, bool $flush = true): void
     {
         $apiCall->setStatusCode($statusCode);
-        $this->processMonitor->end($apiCall, $statusCode >= 200 && $statusCode < 300, $flush);
+        $this->processMonitor->end($apiCall, $statusCode >= Response::HTTP_CONTINUE && $statusCode < Response::HTTP_BAD_REQUEST, $flush);
+    }
+
+    public function getProcessMonitor(): ProcessMonitor
+    {
+        return $this->processMonitor;
     }
 }

src/Query/MySQL/GroupConcat.php

@@ -54,7 +54,7 @@ public function parse(\Doctrine\ORM\Query\Parser $parser): void
         }
 
         if ($lexer->isNextToken(Lexer::T_IDENTIFIER)) {
-            if (strtolower($lexer->lookahead['value']) !== 'separator') { // @phpstan-ignore-line
+            if (strtolower($lexer->lookahead['value']) !== 'separator') {
                 $parser->syntaxError('separator');
             }
             $parser->match(Lexer::T_IDENTIFIER);