Use target branch name in batch merge to allow multiple instances #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A project can use multiple instances of marge bots assigned to different target branches. This allows dealing with different release branches in parallel. However batches could not be used on multiple instances because they conflicted on the name of the branch created for the batch. By naming this branch after the target branch, then multiple batch branches can exist.
valentindavid
force-pushed
the
multi-target-batch
branch
from
19004f2
to
0585293
Compare
|
@tclh123 Is there a chance that this PR gets merged? |
|
@sg70 Yeah, I think this is good. Not sure if we want it to be configurable? |
|
@valentindavid Thanks for the contribution. Changing the branch name for branch will be a breaking change. Would you please add a configuration that is disabled by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A project can use multiple instances of marge bots assigned to
different target branches. This allows dealing with different
release branches in parallel.
However batches could not be used on multiple instances because
they conflicted on the name of the branch created for the batch.
By naming this branch after the target branch, then multiple
batch branches can exist.
Fixes #267