Fix TypeError on default font when no fonts available (#466)

* Add test for scenarios where either the page is null or there is no content, both failing on a return type for 'getDefaultFont' * Don't add the font to the set of available fonts when there is no font available * Run csfixer Co-authored-by: prinsfrank <[email protected]>
smalot · Oct 18, 2021 · 4d6864a · 4d6864a
1 parent f5fa4d3
commit 4d6864a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Smalot/PdfParser/PDFObject.php b/src/Smalot/PdfParser/PDFObject.php
@@ -222,7 +222,10 @@ private function getDefaultFont(Page $page = null): Font
             $fonts = $page->getFonts();
         }
 
-        $fonts[] = $this->document->getFirstFont();
+        $firstFont = $this->document->getFirstFont();
+        if (null !== $firstFont) {
+            $fonts[] = $firstFont;
+        }
 
         if (\count($fonts) > 0) {
             return reset($fonts);

diff --git a/tests/Unit/PDFObjectTest.php b/tests/Unit/PDFObjectTest.php
@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Smalot\PdfParser\Unit;
+
+use Smalot\PdfParser\Document;
+use Smalot\PdfParser\Page;
+use Smalot\PdfParser\PDFObject;
+use Tests\Smalot\PdfParser\TestCase;
+
+class PDFObjectTest extends TestCase
+{
+    public function testGetTextOnNullPage(): void
+    {
+        static::assertSame(' ', (new PDFObject(new Document()))->getText());
+    }
+
+    public function testGetTextOnPageWithoutContent(): void
+    {
+        $document = new Document();
+
+        static::assertSame(' ', (new PDFObject($document, null, null))->getText(new Page($document)));
+    }
+}