Encode request/response into buffer to avoid temporary allocations #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
|
The strict validations that are applied now during encoding/decoding might cause issues for devices that don't conform to the spec. Scheduled for v0.16.0 to avoid breaking existing applications. |
|
Tests for lots of edge cases are missing. These should better be discovered by #95. |
No temporary allocation of a separate byte buffer needed.
Co-authored-by: Markus Kohlhase <[email protected]>
Co-authored-by: Markus Kohlhase <[email protected]>
Co-authored-by: Markus Kohlhase <[email protected]>
Co-authored-by: Markus Kohlhase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.