-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Armv7M support for Cortex-M4 and Cortex-M7 #61
Draft
mkannwischer
wants to merge
362
commits into
main
Choose a base branch
from
armv7m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40,691
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regarding the pipeline models, I did some analysis on those already. |
* Introduces loop class for loops that restore the compare-to pointer using a vmov * Modifies mode of operation for loop extraction: The loop instructions need to appear in sequence
* Slight code modification to make loop parsable
Previously the selftest would determine which registers are supposed to contain addresses (and allocate memory accordingly) by going through all memory operations and assuming that address registers used in those are the inputs holding the addresses initially. This assumption does not hold as (1) addresses may be moved around (2) addresses may actually be a result of a previous computation. One example where this did not work was vmov rX, sY ldr tZ, [rX] here the selftest would assume that rX needs to be an address. However, sY is the register holding the address on entry of the code. This commit refines the code determining the address registers by recursively going through the DFG and determining the _input_ registers that affect values being used as addresses. Note that in the above examples rX would not be marked as an address, at it is not an input. Hopefully this approach is more robust.
This allows to access memory at negative offsets.
* Helps in case of ambigous loop types and makes the operation more predictable.
* Fix issue with wrong detection of FPR for storing end-pointer * Move to the end of loop classes (i.e., lowest priority) * Apply BranchLoop to ntt_dilithium example to get deprecate of boundary_reserved_regs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #55