Fix armv7m arch model #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
fix-armv7m
branch
from
8d89d6b to
6bab0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes pulled out of the
armv7mbranch:Setting the arch_name
Fixing the model for vldm/vstm. Small tweaks to the Armv7-M architecture model #116 changed the model for those and incorrectly modelled it as allowing any combination of registers in the register list of vldm/vstm. While this is true for ldm and stm, it doesn't work for vldm/vstm. There it actually need to be a list of consecutive registers (which makes sense because otherwise there are just too many combinations). This lead to an explosion of combinations and, consequently, RAM usage.
Work around LLVM complaining about
.wfor ldr/str instructions with negative offset. These are 32-bit anyway as only the 32-bit encoding allows negative offsets. We cannot fix this in our input code as the address fixup changes the offests. Better ideas are welcome!Fix some warnings about the regexes in the armv7m model.