Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Armv7E-M architecture model #114

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Extend Armv7E-M architecture model #114

merged 2 commits into from
Dec 5, 2024

Conversation

mkannwischer
Copy link
Collaborator

Small tweaks to the Armv7E-M model:

  • Add smlatb and ldrb with postincrement (and corresponding uArch model for M7)
  • make barrel shift parsing more flexibile (can now write either asr#1 or asr #1 (before it was limited to the latter)

@mkannwischer mkannwischer marked this pull request as ready for review December 5, 2024 03:13
Copy link
Collaborator

@dop-amin dop-amin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The limitation about the barrel shift notation was indeed confusing.

@dop-amin
Copy link
Collaborator

dop-amin commented Dec 5, 2024

@mkannwischer If you wanted to, you could add an example that uses the added instructions just to have them "covered" by CI in some place.

@mkannwischer
Copy link
Collaborator Author

We have the examples in the armv7m branch - I hope that we can merge all those soon.

@mkannwischer mkannwischer merged commit 2ebb278 into main Dec 5, 2024
13 checks passed
@mkannwischer mkannwischer deleted the extend-armv7-m branch December 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants