Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for PHP 8.3 #3336

Merged
merged 4 commits into from
Jul 7, 2024
Merged

Fix tests for PHP 8.3 #3336

merged 4 commits into from
Jul 7, 2024

Conversation

odan
Copy link
Contributor

@odan odan commented Jul 7, 2024

This PR should fix multiple compatibility issues with PHP 8.3 for test code only.

Example error message:

PHP Fatal error:  Declaration of Slim\Tests\Mocks\SmallChunksStream::close() 
must be compatible with Psr\Http\Message\StreamInterface::close(): void in 
/home/runner/work/Slim/Slim/tests/Mocks/SmallChunksStream.php on line 41

See here: https://github.com/slimphp/Slim/actions/runs/9737805348/job/26870413208

image

@coveralls
Copy link

Coverage Status

coverage: 99.429% (+0.002%) from 99.427%
when pulling 9a07ee2 on odan:test-php-83
into b8e7b5c on slimphp:4.x.

@coveralls
Copy link

Coverage Status

coverage: 99.427%. remained the same
when pulling 5eeaa19 on odan:test-php-83
into b8e7b5c on slimphp:4.x.

@coveralls
Copy link

Coverage Status

coverage: 99.429% (+0.002%) from 99.427%
when pulling af2b5ac on odan:test-php-83
into b8e7b5c on slimphp:4.x.

@odan odan merged commit f29badd into slimphp:4.x Jul 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants