-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace src with data-src to enable lazy loading #924
base: master
Are you sure you want to change the base?
Replace src with data-src to enable lazy loading #924
Conversation
I cannot see a lot of difference in performance, e.g., between the same presentation on http://localhost:3000/presentation/2201-1/test-a-big-big-big-deck/2201-1 /#/slide-12856-1 and on https://platform.experimental.slidewiki.org/presentation/2201-1/test-a-b ig-big-big-deck/2201-1/#/slide-12788-1 (without data-src)
According to my tests it is a little faster for the initial load (e.g. useful for mobile users) and only preloads images for the first two slides. If an image has been once loaded, it is not discarded as the user navigates away from the slide. Thus all loaded images will stay in the DOM/Browser. |
Thanks for investigating this @rmeissn !! |
Regarding offline access - we have the HTML download for that which I have used at conferences. I think we should promote this as the ideal option where internet connection is unreliable. |
Thanks for the feedback! I think the switch button is better, as I would normally prefer non-lazy loading while presenting. We can then still have a tooltip. |
I will try to measure the speedup of this option, so we have some reliable data to decide if it's worth spending the time. @bwulff Could you setup all services at testing and the database of slidewiki.org? I would prefer to use a server that is not used much for these kinds of tests. I will probably be able to test on 03 to 05 July. |
I cannot see a lot of difference in performance, e.g., between the same
presentation on
http://localhost:3000/presentation/2201-1/test-a-big-big-big-deck/2201-1
/#/slide-12856-1 and on
https://platform.experimental.slidewiki.org/presentation/2201-1/test-a-b
ig-big-big-deck/2201-1/#/slide-12788-1 (without data-src)