Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override user-provided html files #1926

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: do not override user-provided html files #1926

merged 1 commit into from
Nov 14, 2024

Conversation

KermanX
Copy link
Member

@KermanX KermanX commented Nov 1, 2024

fix #1923

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 78cadad
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/67249bedb9e2f600085ceeff
😎 Deploy Preview https://deploy-preview-1926--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 1, 2024

Open in Stackblitz

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1926

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1926

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1926

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1926

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1926

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1926

commit: 78cadad

@tschaub
Copy link

tschaub commented Nov 1, 2024

Thanks for the quick fix, @KermanX!

Here is a working example using this fix: https://stackblitz.com/edit/wzuhnt?file=README.md

As mentioned there, a plugin is still needed to get slidev build to include the iframe sources. Perhaps that could be addressed with a fix for #1921.

@KermanX KermanX merged commit feae414 into main Nov 14, 2024
20 checks passed
@KermanX KermanX deleted the fix/1923 branch November 14, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The slidev:config plugin doesn't allow Vite to serve other html files
2 participants