Skip to content

Commit

Permalink
feat(ingestion): add ability to specify data dictionary mode for ora…
Browse files Browse the repository at this point in the history
…cle module (1.fix integration tests 2.update golden-files 3.delete debug rows 4.fix mypy tests)
  • Loading branch information
sleeperdeep committed Jan 25, 2024
1 parent f52aae4 commit ba98c4f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/sql/oracle.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging
import re
from typing import Any, Dict, Iterable, List, NoReturn, Optional, Tuple, cast
from typing import Any, Dict, Iterable, List, NoReturn, Optional, Tuple, Union, cast
from unittest.mock import patch

# This import verifies that the dependencies are available.
Expand Down Expand Up @@ -516,7 +516,7 @@ def fkey_rec():

def get_view_definition(
self, view_name: Optional[str], schema: Optional[str] = None
) -> str | None:
) -> Union[str, None]:
view_name = self._inspector_instance.dialect.denormalize_name(view_name)
schema = self._inspector_instance.dialect.denormalize_name(
schema or self.default_schema_name
Expand Down

0 comments on commit ba98c4f

Please sign in to comment.