Unverified Buyer List #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of unverified buyers now show to admin user. Admin user can now update status of a buyer.
| @@ -1,8 +1,9 @@ | |||
| angular.module('jasmic.controllers') | |||
| .controller('AdministratorCtrl', ['$scope','$mdDialog', '$mdToast','UsersFactory','CropsFactory','SuppliersFactory', | |||
| .controller('AdministratorCtrl', ['$scope','$mdDialog', '$mdToast','$window','UsersFactory','CropsFactory','SuppliersFactory', | |||
| 'UserFactory','CropFactory','SupplierFactory', 'EmailFactory', 'UserProfileFactory', 'ParishesFactory', | |||
There was a problem hiding this comment.
@matjames007 I encountered an issue after updating a buyer. The screen would turn grey but the dialog box was not seen. In testing the branch, you can remove the $window.scroll line to see if you get encounter this behaviour.
There was a problem hiding this comment.
I haven't seen the behaviour described. I also haven't seen the $window.scroll line u mentioned. Could you point me to the file and line number on this branch?
| @@ -236,6 +264,7 @@ angular.module('jasmic.controllers') | |||
| */ | |||
| function updateSupplier(){ | |||
| SupplierFactory.update({id:$scope.supplier._id}, $scope.supplier, function(success){ | |||
| $window.scrollTo(0,0); | |||
There was a problem hiding this comment.
@matjames007 here's the reference to the line.
There was a problem hiding this comment.
oh when u are updating the supplier! not the buyer...lol ok
There was a problem hiding this comment.
@matjames007 actually both! lol..
…re properly. Now the issue is that the parent is usually the body element and it will always try to centre relative to the top of the page. So the best way to centre is based on the object being manipulated. I wrote code to pull the item being manipulated and set as dialog parent. Achieved by using an overloaded function. Matthew Budram
Conflicts: public/javascripts/controllers/admin-ctrl.js
…roots/jas-mis-app into unverified-buyer-list-impl
Conflicts: public/javascripts/controllers/admin-ctrl.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of unverified buyers now show to admin user. Admin user can now update status of a buyer.