Front- and back-end for all the cards on the buyer and farmer pages + editing of the same + table-lists to replace some cards #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
August 11, 2015 11:19
…id's design for the supplier card and decide on a prettier way for the Edit function to be triggered.
…ment David's design for the supplier card and decide on a prettier way for the Edit function to be triggered." This reverts commit ec60759.
…it from this one. Same supplier edit functionality as before.
…better Edit button for the supplies.
…k-end endpoints to carry out the updates.
…. Everything works correctly now.
nickwleo
changed the title
nickwleo
changed the title
| 'BuyerTypesListingFactory', 'OpenTransactionsFactory', 'TransactionsFactory', 'RepFactory', 'CropsFactory', 'UnitsFactory', | ||
| 'BuyerDemandFactory', 'DemandsFactory', | ||
| 'BuyerTypesListingFactory', 'OpenTransactionsFactory', 'TransactionsFactory', 'RepFactory', 'RepEditFactory', 'CropsFactory', 'UnitsFactory', | ||
| 'BuyerDemandFactory', 'DemandEditFactory', 'DemandsFactory', |
There was a problem hiding this comment.
@nick22891 A suggestion here, instead of write more services/factories (DemandEditFactory), we could add the update verb to the DemandFactory already in place, since the DemandFactory shows a Demand by id. Less lines of code = Less bugs.
|
This pull request can be reviewed again now. |
| $scope.editDemandForm = function (index) { | ||
|
|
||
| $scope.edit_demand = !$scope.edit_demand; | ||
|
|
There was a problem hiding this comment.
Why the extra line break for every line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to do with updating different things and the corresponding front-ends/cards. Some other small miscellaneous fixes too as per issues in Waffle.
This is the big upcoming pull request I was talking about. Will definitely keep them smaller and on separate branches for each feature going forward as advised.