Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support templates #162

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

Support templates #162

wants to merge 76 commits into from

Conversation

Gouvernathor
Copy link
Collaborator

@Gouvernathor Gouvernathor commented May 27, 2024 •
edited
Loading

Left TODO:

  • allow the Vacants to be renamed and reordered
  • maybe allow more extended data
  • allow for a reversed template which implies...
    • allow metadata in templates
  • update the template standard specification
    • maybe use a parameter namespace for both the ids, and the metadata as parameters to the svg node
      • put the spec online at the namespace URI
    • probably ditch the multi-area spec, or reserve it as an extended spec that's not (yet) supported by the tool
  • remove all things related to area ?
  • Add the Sejm ?
  • Fill in the description

@Gouvernathor Gouvernathor linked an issue May 27, 2024 that may be closed by this pull request
Allow various parliament layouts #42
Open
@Gouvernathor
Add skeleton for handling templates
1a4255b 
The specification of the accepted format is here https://gist.github.com/Gouvernathor/5825f5ce09b98c31343f798faeaebebe
There are two competing implems : one using the ET module and the other using regexes. While ET may be able to handle corner cases more elegantly, it is vulnerable to XML attacks where re is not.
@Gouvernathor
Add main function and fix types
c1673d3
@Gouvernathor
Use strict zip
014dd43
@Gouvernathor
Add another template ET filler function
96fd762
@Gouvernathor
Fix xpath expression
f3ef67c
@Gouvernathor
Use @ as id special character, for tests
1aa971e
@Gouvernathor
Fix recursion
7c3fc3c
@Gouvernathor
Pop invalid id
b052fd7
@Gouvernathor
Ugly trick
583f6a4 
this is test-only, I promise
@Gouvernathor
Commit working code
315c4a2
@Gouvernathor
Clean messy and useless namespaces
b8f8077
@Gouvernathor
Factorize the namespaces circumvention
5d59e79
@Gouvernathor
Add the rainbow demo feature
7941bbd
@Gouvernathor
Enable demo without ET
7eee54b
@Gouvernathor
Change the rainbow born
1f61c5e
@Gouvernathor
Start the party numbers at 1 instead of 0
b0f1eeb
@Gouvernathor
Fix single-area use case for the str version
9e1deea
@Gouvernathor
Commit french assnat template
220c115 
Generated from the parliamentarch french-hemi branch, after inverting the id numbering (to have it from let to right)
@Gouvernathor
Put the namespaces first (as they usually are)
8dd3859
@Gouvernathor
Better formatting of style node
f9dc92a
@Gouvernathor
Move the python file
c3ea2c7
@Gouvernathor
Move assnat template to a templates folder
0f08623 
not to be confused with flask template files which are html
@Gouvernathor
Don't use simplistic font
ea8a65b 
not needed now that bootstrap has a better default value
@Gouvernathor
Add templates skeleton
50305ff
@Gouvernathor
Duplicated property
7a00cf6
@Gouvernathor
Copy link
Collaborator Author

Idea (possible subsequent reimplementation) : implement all the templates business logic in JS, rather than python, so that it executes on the client side. We just have to send the svg template, and let it be filled using basic XML handling stuff MDN documents very well. Con : harder to use locally by command line.

@Gouvernathor Gouvernathor marked this pull request as ready for review July 12, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow various parliament layouts
1 participant
@Gouvernathor