Remove change that was breaking webapp unit tests (#93)

* validate data integrity for json columns * added comment * remove line that was breaking a bunch of unit tests in webapp, add check for strictSQLMode before validating json column data * use ubuntu 20.04 (#94) * use ubuntu 20.04 * fix linter * remove check for sql strict mode before validating json data --------- Co-authored-by: Kevin Tabb <[email protected]> Co-authored-by: Scott Sandler <[email protected]>
slackhq · Feb 9, 2023 · a32bc1d · a32bc1d
1 parent fa63954
commit a32bc1d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/DataIntegrity.php b/src/DataIntegrity.php
@@ -179,7 +179,6 @@ public static function ensureFieldsPresent(dict<string, mixed> $row, table_schem
               }
             } else {
               $field_value = (string)$row[$field_name];
-
               // handle json column type validation
               if ($field_mysql_type === DataType::JSON) {
                 // null is okay

diff --git a/src/Expressions/InOperatorExpression.php b/src/Expressions/InOperatorExpression.php
@@ -60,7 +60,7 @@ public function evaluateImpl(row $row, AsyncMysqlConnection $conn): bool {
           }
         }
       } else {
-        if ($value == $in_expr->evaluate($row, $conn)) {
+        if (\HH\Lib\Legacy_FIXME\eq($value, $in_expr->evaluate($row, $conn))) {
           return !$this->negated;
         }
       }