Skip to content

Commit

Permalink
Update connect signature newer hhvm version support (#66)
Browse files Browse the repository at this point in the history
* Update connect signature
Required for hhvm (4.81 or 4.82?) and above
facebook/hhvm@b2b9806

* Remove lint silencers
They were added by me ages ago.
  • Loading branch information
lexidor authored Feb 25, 2021
1 parent d9aef42 commit 286eeb6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .hhconfig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
hackfmt.line_width=120
assume_php=false
allowed_decl_fixme_codes=2053,3012,4045,4047
allowed_fixme_codes_strict=2011,2049,2050,2053,2083,3012,3084,4027,4045,4047,4104,4106,4107,4108,4110,4128,4135,4188,4223,4240,4323
allowed_fixme_codes_strict=2011,2049,2050,2053,2083,3012,3084,4027,4045,4047,4104,4106,4107,4108,4110,4128,4135,4188,4223,4240,4323,4341,4390,4401
3 changes: 1 addition & 2 deletions src/AsyncMysql/AsyncMysqlClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

use namespace HH\Lib\Vec;

/* HHAST_IGNORE_ALL[UnusedParameter] */

<<__MockClass>>
final class AsyncMysqlClient extends \AsyncMysqlClient {

Expand All @@ -25,6 +23,7 @@ public static function setPoolsConnectionLimit(int $_limit): void {}
int $_timeout_micros = -1,
?\MySSLContextProvider $_ssl_provider = null,
int $_tcp_timeout_micros = 0,
string $_sni_server_name = '',
): Awaitable<\AsyncMysqlConnection> {
return new AsyncMysqlConnection($host, $port, $dbname);
}
Expand Down
6 changes: 2 additions & 4 deletions src/AsyncMysql/AsyncMysqlConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

use namespace HH\Lib\Vec;

/* HHAST_IGNORE_ALL[UnusedParameter] */

<<__MockClass>>
final class AsyncMysqlConnection extends \AsyncMysqlConnection {

Expand Down Expand Up @@ -39,8 +37,8 @@ public function __construct(private string $host, private int $port, private str
<<__Override>>
public async function query(
string $query,
int $timeout_micros = -1,
dict<string, string> $query_attributes = dict[],
int $_timeout_micros = -1,
dict<string, string> $_query_attributes = dict[],
): Awaitable<AsyncMysqlQueryResult> {
Logger::log(Verbosity::QUERIES, "SQLFake [verbose]: $query");

Expand Down

0 comments on commit 286eeb6

Please sign in to comment.