add failing test (#50)

* fix parsing for strings ending in \'

* Update InsertQueryTest.php

src/Parser/Lexer.php

@@ -82,7 +82,8 @@ private function groupComments(dict<int, string> $tokens): dict<int, string> {
       // we need to handle sequences that look like comments, but are inside quoted strings. to do that, we also need to know when quoted strings start and end
       // since a comment could contain a quote, and a quote could contain a comment, we can't safely process either first without being aware of the other
       // so first we check if the next token should be escaped, and then if it's a quote character
-      if ($token === '\\') {
+      // checking for !$escape_next here checks for \\\\ sequences
+      if ($token === '\\' && !$escape_next) {
         $escape_next = true;
       } else {
         $escape_next = false;

tests/InsertQueryTest.php

@@ -13,8 +13,8 @@ final class InsertQueryTest extends HackTest {
   public static async function beforeFirstTestAsync(): Awaitable<void> {
     init(TEST_SCHEMA, true);
     $pool = new AsyncMysqlConnectionPool(darray[]);
-    static::$conn = await $pool->connect("example", 1, 'db1', '', '');
-    // block hole logging
+    static::$conn = await $pool->connect('example', 1, 'db1', '', '');
+    // black hole logging
     Logger::setHandle(new \Facebook\CLILib\TestLib\StringOutput());
   }
 
@@ -306,4 +306,20 @@ final class InsertQueryTest extends HackTest {
     ]);
   }
 
+  public async function testDupeInsertEscaping(): Awaitable<void> {
+    $conn = static::$conn as nonnull;
+    await $conn->query(<<<'EOT'
+      INSERT INTO table1 (`id`,`name`) VALUES (123456789, 'xÚdfíá()ÊÏMÊÏKòáÂÕÿfl©99ùåp>sQj¤Ø©¸¨©=)7±(I{^PSj\\%Krbv*+#©¶ Ì\0Ma\0a\0¤Ý7\\')
+      ON DUPLICATE KEY UPDATE `name`='xÚdfíá()ÊÏMÊÏKòáÂÕÿfl©99ùåp>sQj¤Ø©¸¨©=)7±(I{^PSj\\%Krbv*+#©¶ Ì\0Ma\0a\0¤Ý7\\'
+EOT
+    );
+    $results = await $conn->query("SELECT * FROM table1");
+    expect($results->rows())->toBeSame(vec[
+      dict[
+        'id' => 123456789,
+        'name' =>
+          "xÚdfíá()ÊÏMÊÏKòáÂÕÿfl©99ùåp>sQj¤Ø©¸¨©=)7±(I{^PSj\%Krbv*+#©¶ Ì\0Ma\0a\0¤Ý7\\",
+      ],
+    ]);
+  }
 }