Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granularize skippy configs for future work #678

Merged
merged 28 commits into from
Dec 12, 2023
Merged

Conversation

ZacSweers
Copy link
Collaborator

This is a part one toward exposing granular skippy configurations per tool. Currently it's still implemented in the project computer the same as before and just merges them all together, but will continue that work in subsequent PRs.

One thing I'm curious for thoughts on in this PR is if this approach of having the AffectedProjectsComputer makes sense, or if it might be better to keep it implemented the same as before and run multiple computer runs in parallel instead (where each task corresponds to the tool it's computing for). Then at the end we could aggregate their computed affected projects files and merge them. I'm leaning toward the latter but keen for thoughts!

Copy link
Collaborator

@valeraz valeraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallelized approach would be nice. Since this will be running at the start of every CI build, it'd be nice to squeeze whatever performance we can out of it.

@ZacSweers
Copy link
Collaborator Author

Ok I've taken a pass at extracting an intermediary SkippyRunner API that can run multiple configs and reuse the existing AffectedProjectComputer. This came through quite nicely as it keeps the core of skippy more or less unchanged, and just adds APIs for supporting

  • Supporting multiple configs
  • Supporting overlaying global config onto custom configs
  • Computing them in parallel
  • Merging their outputs (also in parallel)

@ZacSweers ZacSweers added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 7d3a11a Dec 12, 2023
3 checks passed
@ZacSweers ZacSweers deleted the z/granularSkippyConfigs branch December 12, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants