-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granularize skippy configs for future work #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parallelized approach would be nice. Since this will be running at the start of every CI build, it'd be nice to squeeze whatever performance we can out of it.
Ok I've taken a pass at extracting an intermediary
|
This is a part one toward exposing granular skippy configurations per tool. Currently it's still implemented in the project computer the same as before and just merges them all together, but will continue that work in subsequent PRs.
One thing I'm curious for thoughts on in this PR is if this approach of having the AffectedProjectsComputer makes sense, or if it might be better to keep it implemented the same as before and run multiple computer runs in parallel instead (where each task corresponds to the tool it's computing for). Then at the end we could aggregate their computed affected projects files and merge them. I'm leaning toward the latter but keen for thoughts!