Feature Flag Annotator #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Sep 21, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/SkatePluginSettings.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/featureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/featureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/featureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagAnnotatorTest.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/test/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagAnnotatorTest.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/featureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 22, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 25, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/PsiElementExtensions.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/PsiElementExtensions.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 27, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/PsiElementExtensions.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 27, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/PsiElementExtensions.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 27, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagAnnotator.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/featureflags/FeatureFlagExtractor.kt
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/SkatePluginSettings.kt
Show resolved
Hide resolved
…nsure flag name and URL value is not empty when Feature Flag is enabled
arpita184
commented
Sep 28, 2023
skate-plugin/src/main/kotlin/com/slack/sgp/intellij/SkatePluginSettings.kt
Show resolved
Hide resolved
ZacSweers
reviewed
Sep 28, 2023
ZacSweers
reviewed
Sep 28, 2023
skate-plugin/src/main/resources/messages/skateBundle.properties
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/resources/messages/skateBundle.properties
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/resources/messages/skateBundle.properties
Outdated
Show resolved
Hide resolved
skate-plugin/src/main/resources/messages/skateBundle.properties
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR enhances the user experience by implementing automated linking of feature flags. It enables users to quickly access feature flag links through inspections for corresponding enum entries.
Key Features:
Automated Scanning: Detects enums annotated with the fully-qualified name (com.example.FeatureFlag) in *Feature.kt files.
Direct Linking: Adds inspections to the identified enum entries for seamless navigation to the feature flag links.
How to enable this plugin?