Add compressAndroidTestApksWithLegacyPackaging option #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is a red herring, due to a broken config cache config that is fixed on main but polluted atm |
kateliu20
approved these changes
Dec 10, 2024
valeraz
reviewed
Dec 10, 2024
| * - https://issuetracker.google.com/issues/259832799 | ||
| * - https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/dsl/DexPackagingOptions#useLegacyPackaging:kotlin.Boolean | ||
| */ | ||
| public val minifyAndroidTestApks: Provider<Boolean> |
There was a problem hiding this comment.
could we rename this to compressAndroidTestApks. I'm concerned that minify will get conflated with running shrinking.
There was a problem hiding this comment.
We already have a compress property above this, this is the toe-hold for minification with R8 if there ends up being a way to do that too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.