This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Enable App-Extension-Safe use of API's #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenbot
suggested changes
Aug 17, 2018
| @@ -181,6 +187,7 @@ | |||
| F522538D1CBE2F85002EECA9 /* SLKTypingIndicatorProtocol.h in Headers */, | |||
| F52253951CBE2F85002EECA9 /* UIView+SLKAdditions.h in Headers */, | |||
| F52253851CBE2F85002EECA9 /* SLKTextInputbar.h in Headers */, | |||
| 751FBFFA20B434480073DF8B /* UIApplication+ExtensionSafe.h in Headers */, | |||
There was a problem hiding this comment.
Why does this extension need to be public really?
|
|
||
| @implementation UIApplication (ExtensionSafe) | ||
|
|
||
| + (BOOL)isAppExtension |
There was a problem hiding this comment.
This is unused and unexposed. Do we really need it?
| UIApplication *safeSharedApplication = nil; | ||
|
|
||
| if ([UIApplication respondsToSelector:@selector(sharedApplication)]) { | ||
| safeSharedApplication = [UIApplication performSelector:@selector(sharedApplication)]; |
There was a problem hiding this comment.
Calling [UIApplication sharedApplication] would be just simpler here, don't you think?
| if ([UIApplication respondsToSelector:@selector(sharedApplication)]) { | ||
| safeSharedApplication = [UIApplication performSelector:@selector(sharedApplication)]; | ||
| } | ||
| if (!safeSharedApplication.delegate) { |
There was a problem hiding this comment.
safeSharedApplication.delegate == nil is preferrable
| { | ||
| UIApplication *safeSharedApplication = nil; | ||
|
|
||
| if ([UIApplication respondsToSelector:@selector(sharedApplication)]) { |
There was a problem hiding this comment.
All this logic should probably be executed once and only, by wrapping it in a static dispatch_once_t.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enables safe access of
UIApplication sharedApplicationwhen the framework is included in an application extension target.Related Issues
#670
Test strategy
Verify that project builds and has
Require Only App-Extension-Safe APIenabled.