Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Fixed the iOS11 break of the library #621

Closed
wants to merge 1 commit into from

Conversation

laeroah
Copy link

@laeroah laeroah commented Sep 18, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Should be fixing UI outlets not being interactive on the text input bar since iOS 11.
Port of Recfive@2b4cee5

Related Issues

Should fix #604

@dzenbot dzenbot changed the title fixed the iOS11 break of the library Fixed the iOS11 break of the library Sep 18, 2017
@dzenbot dzenbot added the iOS 11 label Sep 18, 2017
@dzenbot
Copy link

dzenbot commented Sep 19, 2017

Thanks. I will test this out real soon.

@hebertialmeida
Copy link

This is not working for me in edit mode because the buttons to save are cancel are behind the view.

My current workaround is:

if let view = textInputbar.subviews.last, view.frame.size == textInputbar.frame.size {
    textInputbar.sendSubview(toBack: view)
}

I check the size to make sure that will not send the wrong view to the back.

@cerupcat
Copy link

@hebertialmeida Where are you putting your code. This does fix the non-edit solution, but we need to add a fix for editing as well as @hebertialmeida mentioned.

@dzenbot
Copy link

dzenbot commented Sep 21, 2017

Please see #624 which is a less patchy approach.

@dzenbot dzenbot closed this in #624 Sep 22, 2017
@yarodevuci
Copy link

@hebertialmeida Where do I put that code into?

@hebertialmeida
Copy link

@yarodevuci I was using on my viewController, but as @dzenbot mention, there is a better implementation on the master branch, I have switched to that.

@yarodevuci
Copy link

@hebertialmeida I pulled master but have not noticed anything. Is there something wrong am doing?

@Balasubramanian93
Copy link

Hi Guys,

I am facing different issue. Contents drawn on the CGContext of the UIImageView got disappeared. I have attached the video which demonstrates the issue i was facing in my side. I am getting this issue only in iOS 11 iPad. I could not reproduce the issue in iPod/iPhone with iOS 11. Can you please let me know if you have any idea on this?

Video: https://www.dropbox.com/s/7nhnaqdhh8ha7u1/Untitled.zip?dl=0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 11 breaks slacktextviewcontroller
6 participants