Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump runtime version #90

Merged
merged 2 commits into from
Aug 2, 2024
Merged

chore: bump runtime version #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f95f393
chore: bump runtime version
WilliamBergamin Aug 2, 2024
613eb57
Put comments on new line to make healthscore succeed
WilliamBergamin Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bundler/esbuild_bundler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
const result = await esbuild.build({
entryPoints: [options.entrypoint],
platform: "browser",
target: "deno1", // TODO: the versions should come from the user defined input
// TODO: the versions should come from the user defined input

Check warning on line 19 in src/bundler/esbuild_bundler.ts

View workflow job for this annotation

GitHub Actions / Health Score

src/bundler/esbuild_bundler.ts#L19 

Problematic comment ("TODO") identified
target: "deno1",
format: "esm", // esm format stands for "ECMAScript module"
bundle: true, // inline any imported dependencies into the file itself
absWorkingDir: options.absWorkingDir,
Expand Down
2 changes: 1 addition & 1 deletion src/install_update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
// project as a means to cache the changes
if (!updateResp.error) {
try {
// TODO :: This try/catch should be nested within createUpdateResp
// TODO: This try/catch should be nested within createUpdateResp

Check warning on line 45 in src/install_update.ts

View workflow job for this annotation

GitHub Actions / Health Score

src/install_update.ts#L45 

Problematic comment ("TODO") identified
// but doing so surfaces an issue with the --allow-run flag not
// being used, despite its presence and success at this level
runBuildHook();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const DENO_SLACK_HOOKS = "deno_slack_hooks";
export const DENO_SLACK_RUNTIME = "deno_slack_runtime";

export const VERSIONS = {
[DENO_SLACK_RUNTIME]: "1.1.1",
[DENO_SLACK_RUNTIME]: "1.1.2",
[DENO_SLACK_HOOKS]: hooksVersion,
};

Expand Down
Loading