Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give health score a shot #85

Merged
merged 2 commits into from
May 13, 2024
Merged

Give health score a shot #85

merged 2 commits into from
May 13, 2024

Conversation

filmaj
Copy link

@filmaj filmaj commented May 10, 2024

Testing out this alpha GitHub Action we are working on

@filmaj filmaj self-assigned this May 10, 2024
@filmaj filmaj requested a review from a team as a code owner May 10, 2024 20:38
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (9ad0848) to head (441f208).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          17       17           
  Lines         776      776           
  Branches      129      129           
=======================================
  Hits          603      603           
  Misses        172      172           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sick 💯 but not sure about the token naming, is this for testing?

Also is -572 good or bad?

- name: Report health score
uses: slackapi/[email protected]
with:
codecov_token: ${{ secrets.FILS_CODECOV_API_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct token to use?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just wanted to make it clear which human user the API token belongs to (in case I e.g. get hit by a bus)

@filmaj
Copy link
Author

filmaj commented May 13, 2024

According to Slack internal Health Score, a score of 0 is perfection, and each identified problem contributes a negative score.

@filmaj
Copy link
Author

filmaj commented May 13, 2024

You can click the check to see a breakdown of how the score is calculated.

@filmaj filmaj merged commit d26df34 into main May 13, 2024
5 checks passed
@filmaj filmaj deleted the health-score branch May 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants