Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the plateform to support more imports #74

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR introduces a patch that allows ebuild to bundle a wider range of npm specifiers note that this is not a full proof solution and that packages such as axios will bundle correctly but create runtime errors

Testing

  1. create an app that uses an npm specifier example dayjs
import dayjs from "npm:[email protected]";

const test = dayjs("2018-08-08");
console.log(test.year());
  1. run slack deploy
  2. The app should bundle and run as expected

Requirements

@WilliamBergamin WilliamBergamin added bug Something isn't working semver:patch requires a patch version number bump labels Nov 7, 2023
@WilliamBergamin WilliamBergamin self-assigned this Nov 7, 2023
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner November 7, 2023 20:07
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #74 (bc07145) into main (64847de) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files          16       16           
  Lines         813      813           
  Branches      111      111           
=======================================
  Hits          628      628           
  Misses        182      182           
  Partials        3        3           
Files Coverage Δ
src/bundler/esbuild_bundler.ts 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 :shipit:

@WilliamBergamin WilliamBergamin merged commit 7ed7ea2 into main Nov 7, 2023
4 checks passed
@WilliamBergamin WilliamBergamin deleted the improve-esbuild branch November 7, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver:patch requires a patch version number bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants