Skip to content

Commit

Permalink
feat: remove the returned minimum version from hook responses
Browse files Browse the repository at this point in the history
  • Loading branch information
zimeg committed Mar 22, 2024
1 parent 96374f3 commit 6045d51
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions src/doctor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ type RuntimeVersion = {
} & RuntimeDetails;

type RuntimeDetails = {
minimum?: string;
message?: string;
error?: {
message: string;
Expand All @@ -31,12 +30,11 @@ const getHostedDenoRuntimeVersion = async (): Promise<RuntimeDetails> => {
: undefined;
if (isNewSemverRelease(Deno.version.deno, version)) {
return {
minimum: version,
message,
error: { message: "The installed runtime version is not supported" },
};
}
return { minimum: version, message };
return { message };
} catch (err) {
if (err instanceof Error) {
return { error: { message: err.message } };
Expand Down
2 changes: 0 additions & 2 deletions src/tests/doctor_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ Deno.test("doctor hook tests", async (t) => {
{
name: "deno",
current: "1.101.1",
minimum: "1.101.1",
message: undefined,
},
{
Expand Down Expand Up @@ -108,7 +107,6 @@ Deno.test("doctor hook tests", async (t) => {
{
name: "deno",
current: "1.2.3",
minimum: "1.101.1",
message: "Applications deployed to Slack use Deno version 1.101.1",
error: {
message: "The installed runtime version is not supported",
Expand Down

0 comments on commit 6045d51

Please sign in to comment.