Auto-triggering: don't retrigger if there are recently (<12 h) failed requests #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nabeelre should be as simple as this. Let's run it with 12 hours to not add extra complexity with moving arguments around, and if we're happy with the behavior but we need another timeout value, we'll make it dynamic. |
nabeelre
reviewed
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when SEDM marked a request as failed (which happens every now and then), BTSbot would retrigger, and that could happen multiple times.
Here we make sure to keep recently (less than 12 hours) failed requests as "existing requests", to avoid triggering again. It's essentially a 12-hour timeout, which means we don't re-trigger until the next time (that is, if the requests is still failed, but most of the time these are re-processed manually in the daytime).