-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from the silver searcher to ripgrep #738
Conversation
ad466c8
to
956c0ed
Compare
@skwp this seems super nice. Any thoughts? @stevenbarragan the branch has conflicts now :/ |
@lfilho merge conflicts fixed. |
@skwp any thoughts about this PR? or maybe you need some help maintaining the repo? I've seen some PR's stay open for ever |
Sorry guys, I've really been unable to do a good job maintaining. I'm revisiting the PRs |
My main issue with this it will break a lot of people who don't have it brew installed and just pull on the repo. Why not provide this as a new mapping |
vim/settings/ctrlp.vim
Outdated
" Use rg in CtrlP for listing files. Lightning fast and respects .gitignore | ||
let g:ctrlp_user_command = 'rg --files --smart-case %s' | ||
|
||
" rg is fast enough that CtrlP doesn't need to cache | ||
let g:ctrlp_use_caching = 0 | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would do a fallback to ag here
Also worth noting that ag.vim has been deprecated: rking/ag.vim#124 (comment). |
Speaking of backwards compatibilities, should we try to avoid key mappings too specific for plugins? For example, instead of This way we would be less dependent and coupled with which plugins provide certain features... |
We do have a generic mapping of |
Sorry guys I had to revert, it turns out ripgrep doesn't install cleanly on my machine. It tried to compile but failed. Until I understand that I dont' want to break other people |
|
That's weird. I installed via brew and it works fine.
|
I'm sorry about that, I didn't have any issue either, I'll take a look. |
@skwp sanity check: have you update your brew recently? I'm running brew 1.2.1, OSX El Capitan and zsh 5.3.1 |
@stevenbarragan and @skwp did you have a chance to have a look? I think this PR will greatly speed things for everyone in #661 |
ripgrep is faster than {grep, ag, git grep, ucg, pt, sift}.
check this blog post.