Prevents trying to fetch page if its URL is invalid (eg. "#")

skttl · Feb 10, 2024 · de5eade · de5eade
1 parent 4d82842
commit de5eade
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Our.Umbraco.FullTextSearch/Rendering/HttpPageRenderer.cs b/src/Our.Umbraco.FullTextSearch/Rendering/HttpPageRenderer.cs
@@ -34,6 +34,12 @@ public virtual async Task<string> Render(IPublishedContent publishedContent, Pub
     {
         var publishedPageUrl = publishedContent.Url(mode: UrlMode.Absolute);
 
+        if (!Uri.TryCreate(publishedPageUrl, UriKind.Absolute, out var url))
+        {
+            _logger.LogInformation("Unable to render page {NodeId}, url returned is invalid ({Url})", publishedContent.Id, publishedPageUrl);
+            return string.Empty;
+        }
+
         try
         {
             // Using a named client to allow for configuration of default headers, cookies and more during service registration