Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Parser.flatMap() in favor of Parser.transformEither() #25

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Deprecate Parser.flatMap() in favor of Parser.transformEither() #25

merged 2 commits into from
Jan 7, 2024

Conversation

routis
Copy link

@routis routis commented Jan 5, 2024

The PR closes #24 by:

  • Deprecating current implementation of Parser.flatMap
  • Adding a new function Parser.transformEither() to replace the deprecated flatMap
  • Adding a new flatMap function with the expected shape.

@routis routis changed the title Deprecated Parser.flatMap() in favor of Parser.transformEither() Deprecate Parser.flatMap() in favor of Parser.transformEither() Jan 5, 2024
@sksamuel
Copy link
Owner

sksamuel commented Jan 7, 2024

I like these changes, much clearer.

@sksamuel sksamuel merged commit b5b0f9c into sksamuel:master Jan 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected shape of Parser.flatMap()
2 participants
@routis @sksamuel