Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporarily skip ken embedding download tests #901

Merged
merged 1 commit into from
Apr 29, 2024
Merged

temporarily skip ken embedding download tests #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions skrub/datasets/tests/test_ken_embeddings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ def test_fetch_ken_types():
assert types3.shape[0] == 2532


# TODO: mock download in test & make download more robust & better error messages
# See https://github.com/skrub-data/skrub/issues/900
@pytest.mark.skip("Downloads large files and fails CI unpredictably")
def test_small_ken_embeddings():
"""
Test if small sized embeddings were fetched correctly
Expand All @@ -54,6 +57,9 @@ def test_small_ken_embeddings():
assert emb2.shape[1] == 7


# TODO: mock download in test & make download more robust & better error messages
# See https://github.com/skrub-data/skrub/issues/900
@pytest.mark.skip("Downloads large files and fails CI unpredictably")
def test_big_ken_embeddings():
"""
Test if bigger sized embeddings were fetched correctly
Expand Down
Loading