better handling of timedelta in tablereport #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-Maladiere
approved these changes
Nov 24, 2024
| @@ -112,3 +112,22 @@ def default(self, value): | |||
| if isinstance(value, np.floating): | |||
| return float(value) | |||
| raise | |||
|
|
|||
|
|
|||
| def duration_to_numeric(col): | |||
There was a problem hiding this comment.
I like this simple but robust heuristic
|
thanks @Vincent-Maladiere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1132
this converts the duration/timedelta columns to numeric so we get a histogram & summary statistics rather than a bar plot
durations and datetimes are also converted to numeric for the column associations detection
the choice of time unit & conversion could probably be improved but this is already better than treating them as categorical