Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem Page 'RUN' 기능 동작 #199

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Problem Page 'RUN' 기능 동작 #199

wants to merge 22 commits into from

Conversation

jimin9038
Copy link
Member

Problem 페이지에서 코드를 실행해볼 수 있도록 Run, Add testcase 기능 추가

Add testcase 모달 (OK시에만 저장)
image

Run 결과
image

Compile error / Syntax error 시
image

benhenryL and others added 16 commits July 31, 2021 15:49
@benhenryL @jimin9038
Enable running code before submission
8d06d20 
dispatcher에서 compiler error 등 발생하는 경우 아직 처리하지 않음
@benhenryL @jimin9038
Handle the case of compile error and system error
20ef37b 
++ response.data의 err가 null 이면 정상적으로 작동한 것이고 compile error면 컴파일 에러가 발생한 것. 이경우 response.data.data에 error msg가 담겨져 있음
@benhenryL @jimin9038
Handle the case of compile error and system error
b6f12da 
++ response.data의 err가 null 이면 정상적으로 작동한 것이고 compile error면 컴파일 에러가 발생한 것. 이경우 response.data.data에 error msg가 담겨져 있음
@benhenryL @jimin9038
Submission: Remove redundant code
e82ae0e
@benhenryL @jimin9038
Specify the type of error
f5d63f1 
++ 코드를 run 해볼 때, 에러가 발생한 경우 에러 내용을 리턴
@y-jiu @jimin9038
Update Problem.vue
2d6dd26 
Added "Add Testcase" modal
@jimin9038
Add feature add testcase & run
ea6f7bf
@jimin9038
Add Testcase modal EdgeCase resolved
ed8ec89
@jimin9038
Add runResults for before api testing
1025b39
@jimin9038
Design RunResult & connect api
95e7ec3
@benhenryL @jimin9038
Run: Handle error regarding WA
afb4570 
+결과가 WA인 경우 redis error가 발생하는 이슈 해결

(cherry picked from commit bb39d04)
@benhenryL @jimin9038
Run: Modify response format
35b627b 
+input도 리턴을 하고, 리턴 형식도 객체 배열을 리턴하게 수정

(cherry picked from commit a978076)
@jimin9038
Run Results design revise
0264deb 
-- API response 구조 변경에 따라 runresults 출력하는 방법과 디자인 바꿈

(cherry picked from commit 9d61a5c)
@jimin9038
runresult compile error design revise
173c665 
(cherry picked from commit d51b0c4)
@jimin9038
RunResults code refactoring
940bae0 
-- await, async 비동기 처리

(cherry picked from commit 6bbb573)
@benhenryL
Modify code to follow the Python code style
37a43c2
@jimin9038 jimin9038 added BE backend tasks enhancement New feature or request FE Frontend tasks labels Jul 31, 2021
@jimin9038 jimin9038 linked an issue Jul 31, 2021 that may be closed by this pull request
Problem Page 'RUN' 기능 동작 #109
Open
dotoleeoak
dotoleeoak requested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@dotoleeoak dotoleeoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout 되는 코드 실행했을 때 redis hash field error가 나오는데, 한번 점검해보세요.

backend/judge/dispatcher.py Outdated Show resolved Hide resolved
backend/judge/dispatcher.py Outdated Show resolved Hide resolved
backend/submission/views.py Outdated Show resolved Hide resolved
backend/judge/dispatcher.py Outdated Show resolved Hide resolved
backend/judge/dispatcher.py Outdated Show resolved Hide resolved
frontend/src/pages/oj/views/problem/Problem.vue Outdated Show resolved Hide resolved
frontend/src/pages/oj/views/problem/Problem.vue Show resolved Hide resolved
frontend/src/pages/oj/views/problem/Problem.vue Show resolved Hide resolved
frontend/src/pages/oj/views/problem/Problem.vue Outdated Show resolved Hide resolved
frontend/src/pages/oj/views/problem/Problem.vue Outdated Show resolved Hide resolved
cyw320712 and others added 4 commits September 8, 2021 23:31
@cyw320712
Apply comments from dotoleeoak
0d291ee
@cranemont
Fix minor issues
8fbf3cb 
redis error 미해결
@cyw320712
Update dispatcher.py
adf50fe
@cranemont
Fix minor issues
0162869 
Check JudgeStatus at frontend
Rename variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhenryL benhenryL Awaiting requested review from benhenryL

@dotoleeoak dotoleeoak Awaiting requested review from dotoleeoak

Requested changes must be addressed to merge this pull request.

Assignees

@cyw320712 cyw320712

@cranemont cranemont

@jimin9038 jimin9038

@benhenryL benhenryL

Labels
BE backend tasks enhancement New feature or request FE Frontend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem Page 'RUN' 기능 동작
6 participants
@jimin9038 @dotoleeoak @cyw320712 @cranemont @benhenryL @y-jiu