refactor(fe): admin problem create page refactoring #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunnbi
requested review from
jwoojin9,
Kohminchae,
jimin9038,
juhyeong0505,
B0XERCAT,
youznn and
Kimhyojung0810
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eunnbi
changed the title
|
진짜 가독성 최고입니다... 👍👍👍 |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-09-19 14:44:06 CET |
|
problem/create 안의 컴포넌트 폴더 이름을 수정해주세요 |
동감합니다.. 👍👍👍 |
수정했습니다! |
mnseok
pushed a commit
that referenced
this pull request
Nov 12, 2024
* feat(fe): add create problem alert dialog component * feat(fe): add create problem form component * feat(fe): add confirm navigation component * chore(fe): add use client directive * refactor(fe): refactor admin problem create page * chore: use not operator * chore: trigger github action * chore(fe): use private folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
주요 변경사항
CreateProblemAlertDialog: graphql mutation 요청CreateProblemForm: 폼 유효성 검사 - 실패 시 caution dialog 열기, 성공 시 create problem alert dialog 열기ConfirmNavigation컴포넌트 추가shouldSkipWarning값을 하위 컴포넌트에서 수정해야 하는 케이스가 존재해서 Context API를 이용해 컴포넌트 버전을 추가했습니다. 다른 좋은 해결 방법 있다면 언제든 환영입니다~마이너 변경사항
use client지시자 추가 (page.tsx에use client지시자 없애서 추가했습니다)closes TAS-920
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).