Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(be): apply global exception filter to admin contest and admin group modules #2099

Merged
merged 5 commits into from
Oct 3, 2024
Merged

refactor(be): apply global exception filter to admin contest and admin group modules #2099

merged 5 commits into from
Oct 3, 2024

Conversation

Jaehyeon1020
Copy link
Member

Description

Closes TAS-911

Admin Contest 모듈과 Group 모듈이 Global Exception Filter를 제대로 사용하도록 리팩토링합니다.

Additional context

Before submitting the PR, please make sure you do the following

@Jaehyeon1020 Jaehyeon1020 self-assigned this Sep 19, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Oct 3, 2024 1:34pm

mnseok
mnseok requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mnseok mnseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겨둔거 하나만 확인해주시면 될 것 같아요

apps/backend/apps/admin/src/contest/contest.service.ts Show resolved Hide resolved
mnseok
mnseok approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mnseok mnseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@Jaehyeon1020
Copy link
Member Author

브랜치 전략 변경 후 머지 예정

@Jaehyeon1020 Jaehyeon1020 marked this pull request as draft September 22, 2024 12:58
@Jaehyeon1020 Jaehyeon1020 marked this pull request as ready for review September 24, 2024 04:18
@jimin9038
Copy link
Member

coolify 배포를 위해서 닫았다가 열게요.

@jimin9038 jimin9038 closed this Sep 26, 2024
@jimin9038 jimin9038 reopened this Sep 26, 2024
@Jaehyeon1020 Jaehyeon1020 changed the title refactor(be): use global exception filter to admin contest and admin group modules refactor(be): apply global exception filter to admin contest and admin group modules Sep 28, 2024
@Jaehyeon1020 Jaehyeon1020 merged commit 49894bc into main Oct 3, 2024
9 checks passed
@Jaehyeon1020 Jaehyeon1020 deleted the t911-refactor-admin-contest-and-group-exception-handling branch October 3, 2024 13:46
mnseok pushed a commit that referenced this pull request Nov 12, 2024
@Jaehyeon1020 @mnseok
refactor(be): apply global exception filter to admin contest and admi…
96004cd 
…n group modules (#2099)

* refactor(be): apply global exception filter to contest module

* refactor(be): apply global exception filter to admin group module

* chore(be): add error handling logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnseok mnseok mnseok approved these changes

@Lee-won-hyeok Lee-won-hyeok Awaiting requested review from Lee-won-hyeok

@jimin9038 jimin9038 Awaiting requested review from jimin9038

@hwantae hwantae Awaiting requested review from hwantae

@cho-to cho-to Awaiting requested review from cho-to

@jspark2000 jspark2000 Awaiting requested review from jspark2000

Assignees

@Jaehyeon1020 Jaehyeon1020

Labels
⛳️ team-backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaehyeon1020 @jimin9038 @mnseok