-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(be): integrate problem exposeTime isVisible #1673
Merged
Jaehyeon1020
merged 48 commits into
main
from
1644-integrate-problem-exposeTime-isVisible
Aug 18, 2024
Merged
fix(be): integrate problem exposeTime isVisible #1673
Jaehyeon1020
merged 48 commits into
main
from
1644-integrate-problem-exposeTime-isVisible
Aug 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cho-to
changed the title
fix(be): integrate problem exposeTIme isVisible
fix(be): integrate problem exposeTime isVisible
May 6, 2024
cho-to
commented
May 29, 2024
Jaehyeon1020
requested changes
May 30, 2024
Jaehyeon1020
requested changes
Aug 9, 2024
Jaehyeon1020
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세달만에 머지.. 수고많으셨습니다!!
…/github.com/skkuding/codedang into 1644-integrate-problem-exposeTime-isVisible
@cho-to 머지해두 되나요 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1644
Closes TAS-267
Closes TAS-268
problem 필드에 존재하는 exposeTime, isVisible 필드에서 isVisible 필드를 제거하고 exposeTime 필드만을 살립니다.
exposeTime, isVisible을 둘 다 살려놓기에는 로직을 짤 때 충돌하는 부분이 많을 것 같아서 exposeTime만을 살려놓는게 나을 것 같다고 생각했습니다. 그래서 isVisible 필드를 제거하고 exposeTime필드로 통일하였습니다!
이때, API 스펙상으로는 변동없이 isVisible을 사용할 수 있도록 하였습니다. (request, response도 exposeTime이 아닌 isVisible 형태로 반환됩니다.) 대신, upcoming/ongoing contest에 속한 Problem의 visibility 설정을 건드릴 시에는 에러를 반환하도록 하였습니다.
또한, upcoming/ongoing contest에 속한 problem의 경우, admin에서 getProblem 통해 접근할시에는 isVisible을 null로 설정하였습니다.
기획상의 변경(대회가 끝나면 문제는 비공개처리가 원칙)으로 exposeTime 필드 이름이 visibleLockTime (isVisible을 수정할 수 있도록 하는 시간) 으로 바뀌었습니다. 필드명, 기획 변경 이외에는 바뀐 점이 없습니다.
위는 시간 , 밑은 isVisible 필드(프론트에게 전달되어지는 값)의 값을 의미합니다.
Additional context
코드에서 논의할만한 부분은 conservation으로 남기겠습니다.
구현한 사항 정리
Before submitting the PR, please make sure you do the following
fixes #123
).