feat(infra): add opentelemetry metric instrumentation #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 5c9d899.
This reverts commit a65f505.
… are already included
…for admin and client api
k1g99
reviewed
Mar 13, 2024
jihorobert
pushed a commit
that referenced
this pull request
Mar 16, 2024
* chore: merge main branch * feat: add codes for automatic instrumentation in client api * feat(infra): rebase main branch * chore(infra): merge tracer into metrics * Revert "chore(infra): merge tracer into metrics" This reverts commit 5c9d899. * chore(infra): merge mian * Revert "feat(infra): rebase main branch" This reverts commit a65f505. * feat(infra): iris memory metrics * refactor(iris): separate application logic from metric-related code * feat(iris): add CPU metrics in iris * chore(iris): add comment of asynchronous metrics * feat(infra): add backend opentelemtry instrumentation for client and admin api * feat(infra): install packages for opentelemetry instrumentation * feat(infra): change iris metric exporter url from env not specifying url * chore(infra): add env of stage-otel * fix(infra): delete grafana agent otlp endpoint variable * feat(infra): install nest package for opentelemetry metric instrumentation * feat(infra): install nest package for opentelemetry metric instrumentation * feat(infra): install go package for iris opentelemetry metric instrumentation * feat(infra): add metric.go functions to main which trace.go functions are already included * feat(infra): add metric.ts functions to main which trace is included for admin and client api * chore: resolve otel dependency * chore: resolve otel dependency for iris * fix(infra): delete files which not in main branch --------- Co-authored-by: k1g99 <[email protected]> Co-authored-by: Goathoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #1298
opentelemetry metric 데이터를 수집하기 위해 [backend의 client와 admin] 과 [iris]에 opentelemetry 코드를 추가하였습니다.
api 서버는 CPU, Memory, Network 데이터를, iris서버는 CPU, Memory 정보를 수집합니다.
API Server의 경우, apps/backend/apps/client/src 와 apps/backend/apps/admin/src폴더에
metric.ts를 생성하여 모듈을 생성하였고, main.ts 에서 해당 모듈을 import하여 사용하였습니다.IRIS Server의 경우 apps/iris/src/observability/ 에 metric.go를 생성하여 main.go에서 이를 받아와 meter를 수집합니다.
opentelemetry 관련된 여러 패키지를 설치하였습니다.
API Server
metric.ts로 모듈 생성 -> import 하여 사용IRIS Server
metric.go로 MeterProvider를 만들고, 이를 통해main.go에서 필요한 metric정보를 얻기 위해 수동으로 생성합니다. (ts진영처럼 자동으로 metric정보를 얻기 위한 sdk가 opentelemetry쪽에서 아직 개발중입니다.Additional context
Before submitting the PR, please make sure you do the following
fixes #123).