nicoll/splits automation #1771
nicoll/splits automation #1771
Conversation
nicollguarnizo
commented
Oct 30, 2024
•
nicollguarnizo
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| @@ -62,28 +62,10 @@ export default defineType({ | |||
| }, | |||
| }), | |||
| defineField({ | |||
| name: 'revenueSplits', | |||
There was a problem hiding this comment.
went ahead and deleted this section
| contributor?: SplitInfo | ||
| } | ||
|
|
||
| const defineSplits = await step.run( |
There was a problem hiding this comment.
define splits based on contributor and moduleType
| "instructor": contributors[0].contributor->{ | ||
| userId, | ||
| name, |
There was a problem hiding this comment.
I'm not a huge fan of this and we should probably not hard code a zero-index lookup here and consider multiple instructors immediately.
| @@ -82,6 +83,114 @@ export const sanityProductCreated = inngest.createFunction( | |||
| }) | |||
| }) | |||
|
|
|||
| type SplitInfo = { | |||
| type: string | |||
There was a problem hiding this comment.
type here is 'owner' | 'skill' | string
could use a discriminated union so that the userId would only be there if it was type owner`
| if (isOwnerInstructor) { | ||
| if (isSelfPaced) { | ||
| splits.skill.percent = 0.4 | ||
| splits.owner.percent = 0.6 | ||
| } else { | ||
| splits.skill.percent = 0.15 | ||
| splits.owner.percent = 0.85 | ||
| } | ||
| } else { | ||
| if (isSelfPaced) { | ||
| splits.skill.percent = 0.5 | ||
| splits.owner.percent = 0.2 | ||
| splits.contributor = { | ||
| type: 'contributor', | ||
| percent: 0.3, | ||
| userId: instructor?.userId, | ||
| } | ||
| } else { | ||
| splits.skill.percent = 0.15 | ||
| splits.owner.percent = 0.15 | ||
| splits.contributor = { | ||
| type: 'contributor', | ||
| percent: 0.7, | ||
| userId: instructor?.userId, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is kind of harsh, but I am concerned with it's hard-coding very specific business values and mutating an object through another object. To the extent that I think we might need to rethink the entire data model and implementation of the PR.
We can keep trying like this or write a plan, diagram the flows, etc before implementing
I'd rather have it just manually added to the database. 😬
| type SplitInfo = { | ||
| type: string | ||
| percent: number | ||
| userId: string | undefined | null | ||
| } | ||
|
|
||
| type Splits = { | ||
| skill: SplitInfo | ||
| owner: SplitInfo | ||
| contributor?: SplitInfo | ||
| } |
There was a problem hiding this comment.
super important to have types exist in 1 spot only
| if (isOwnerInstructor) { | ||
| if (isSelfPaced) { | ||
| splits.skill.percent = 0.4 | ||
| splits.owner.percent = 0.6 | ||
| } else { | ||
| splits.skill.percent = 0.15 | ||
| splits.owner.percent = 0.85 | ||
| } | ||
| } else { | ||
| if (isSelfPaced) { | ||
| splits.skill.percent = 0.5 | ||
| splits.owner.percent = 0.2 | ||
| splits.contributor = { | ||
| type: 'contributor', | ||
| percent: 0.3, | ||
| userId: instructor?.userId, | ||
| } | ||
| } else { | ||
| splits.skill.percent = 0.15 | ||
| splits.owner.percent = 0.15 | ||
| splits.contributor = { | ||
| type: 'contributor', | ||
| percent: 0.7, | ||
| userId: instructor?.userId, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return splits | ||
| }, | ||
| ) |
There was a problem hiding this comment.
oh, looks like it's all repeated
