Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the library to Python 3 #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Navdevl
Copy link

@Navdevl Navdevl commented Jul 17, 2020

The PR has the following set of improvements.

  1. Since Python 2 sunset date is crossed for a while, this PR moved the parts of functionalities using Py3 related ones.
  2. Pickle loaded and dumped the sample files to use Py3 based approach.
  3. Added an output.json file for the other people to easily understand what kind of outputs CVScan provides out of the box by default. (Yes, obviously it can be extended further)
  4. Closes issue [Python 3.6] import converter ModuleNotFoundError: No module named 'converter' #23

What this PR isn't?
This PR didn't fix any of those existing PEP8 issues because for the following reason.

  1. The diff will be too much and will not be easy for the reviewer as to understand how much of the code is added/removed/moved.
  2. Plus, the PR's focus is to Port to Py3 soon and worked solely on that part alone.

Signed-off-by: Naveen Honest Raj K [email protected]

Signed-off-by: Naveen Honest Raj K <[email protected]>
@Navdevl
Copy link
Author

Navdevl commented Feb 9, 2021

@imkarthikk @swaathi If this PR sounds good to merge, can we please try to move this? I have OCD for pending pull requests or any pending items. Hehe. 😅😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants