Count Repetitions #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrs; problem 4-1g - add more detail to clarify already present answer
quick typo
typos (sorry, just being a stickler :p)
Update 04.markdown
Update 03.markdown
We should count only LAST repetitions. If we have repetitions of some first elements and then goes different, the "pivot - repetitions // 2" returns wrong value. For example: we have: 11 11 11 11 8 7 4 21 26 11 after line 18 we have: 11 11 11 11 8 7 4 [11] 21 26 if we counted repetitions by your algorythm the function returns q=5 A[5] = 8, 8 > 7. We broke the main rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should count only LAST repetitions. If we have repetitions of some first elements and then goes different, the "pivot - repetitions // 2" returns wrong value. For example:
we have:
11 11 11 11 8 7 4 21 26 11
after line 18 we have:
11 11 11 11 8 7 4 [11] 21 26
if we counted repetitions by your algorythm the function returns q=5 A[5] = 8, 8 > 7. We broke the main rule.