Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/is 1083 catchup snapshot priority archive #2032

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Bug/is 1083 catchup snapshot priority archive #2032

merged 3 commits into from
Oct 25, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Oct 24, 2024 •
edited
Loading

fixes https://github.com/skalenetwork/internal-support/issues/1083.

reworked syncFromCatchup flag - it doesn't enable downloadSnapshotFlag anymore

tested with functional tests and manually on the devnet

no performance impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev merged commit 7e333f5 into develop Oct 25, 2024
7 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/IS-1083-catchup-snapshot-priority-archive branch October 25, 2024 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dimalit dimalit dimalit approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehnikolaiev @dimalit @DmytroNazarenko