Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALED-1900 release build with separate debug info #2014

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

dimalit
Copy link
Collaborator

@dimalit dimalit commented Sep 30, 2024

  1. All dependencies, are built with -O3 and without -g.
  2. skaled is built with -O3 but WITH -g.
  3. -rdynamic removed.
  4. skaled binary is stripped, but it's copy wit debug info is kept.

CUSTOM BUILD Now contains option to build maximally optimized "Release" configuration

Consequences:

  1. Stack trace printed by skaled on crash will not contain any function names.
  2. gdb will be able to use skaled-debug file to load debug info for original skaled
  3. addr2line will be able to convert addresses from skaled's printed stack trace into source code locations using skaled-debug binary

Testing:
1

objdump -h skaled | grep debug
nm -a skaled

2 Execute strip command on skaled and see that it's size didn't change
3 ojdump -h <file> | grep debug on all project libraries shows no result too.

skaled binary size 29575576

UPDATE This is second attempt of this PR. It fixes dependency from shared library libuv.so

@dimalit dimalit linked an issue Sep 30, 2024 that may be closed by this pull request
@dimalit dimalit merged commit a486b0b into v3.20.0 Sep 30, 2024
6 of 7 checks passed
@dimalit dimalit deleted the enhancement/SKALED-1900-release-build-debug-info branch September 30, 2024 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@DmytroNazarenko DmytroNazarenko linked an issue Oct 2, 2024 that may be closed by this pull request
@dimalit dimalit linked an issue Oct 7, 2024 that may be closed by this pull request
@olehnikolaiev olehnikolaiev restored the enhancement/SKALED-1900-release-build-debug-info branch December 3, 2024 16:06
@olehnikolaiev olehnikolaiev deleted the enhancement/SKALED-1900-release-build-debug-info branch December 3, 2024 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants