Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1911 eth fee history block count #1914

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Bug/1911 eth fee history block count #1914

merged 4 commits into from
Jun 11, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jun 6, 2024 •
edited
Loading

fixes #1911

make eth_feeHistory accept first parameter blockCount either as string or as int.

added unittest

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev merged commit a09a4d2 into develop Jun 11, 2024
5 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1911-eth-feeHistory-blockCount branch June 11, 2024 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex kladkogex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaled return error on eth_feeHistory JSON-call if "blockCount" parameter is integer
3 participants
@olehnikolaiev @kladkogex @DmytroNazarenko