Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1719 eip1559 #1869

Merged
merged 59 commits into from
May 13, 2024
Merged

Feature/1719 eip1559 #1869

merged 59 commits into from
May 13, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Apr 15, 2024

Description

fixes #1719
fixes skalenetwork/metaport#219
spec: https://github.com/skalenetwork/internal-support/blob/main/docs/issues-and-investigations/Type2Transactions.md

Added support for type1 and type2 transactions, added new JSON-RPC API methods, response for some methods was changed (new fields were added).

gasPrice functionality remains the same for legacy and type1 transactions. For type2 transactions maxFeePerGas is interpreted as gasPrice and maxPriorityFeePerGas is ignored.

The way type1 and type2 transactions are written/read to/from database differs from the way corresponding operations are performed for legacy transactions. In order for their rlp to always remain the same they are stored as following: rlp( type + transactionRLP ). legacy transactions are stored just as transactionRLP.

Tests

added new unit tests - send type1 and type2 rlps to skaled.and check their receipts
added new unit tests - call new JSON-RPC methods and verify the response
tested manually by sending type1 and type2 transactions using web3.py, web3.js, ethers.js and skale.py
manually tested integration with blockscout and different wallets
tested with archive node on devnet

Performance Impact

response for some json-rcp calls may take longer potentially, due to the call to prices.db

@olehnikolaiev olehnikolaiev linked an issue Apr 16, 2024 that may be closed by this pull request
@olehnikolaiev olehnikolaiev requested a review from dimalit April 23, 2024 10:32
dimalit
dimalit previously approved these changes Apr 23, 2024
dimalit
dimalit previously approved these changes Apr 24, 2024
@olehnikolaiev olehnikolaiev requested a review from dimalit April 30, 2024 15:27
@olehnikolaiev olehnikolaiev merged commit 006c55a into v3.19.0 May 13, 2024
6 checks passed
@olehnikolaiev olehnikolaiev deleted the feature/1719-eip1559 branch May 13, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of eip-1559 transactions
4 participants