-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1719 eip1559 #1869
Merged
Merged
Feature/1719 eip1559 #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
…iment/1719-proposed-changes
dimalit
previously approved these changes
Apr 23, 2024
dimalit
previously approved these changes
Apr 24, 2024
kladkogex
approved these changes
May 1, 2024
dimalit
approved these changes
May 13, 2024
DmytroNazarenko
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1719
fixes skalenetwork/metaport#219
spec: https://github.com/skalenetwork/internal-support/blob/main/docs/issues-and-investigations/Type2Transactions.md
Added support for
type1
andtype2
transactions, added new JSON-RPC API methods, response for some methods was changed (new fields were added).gasPrice
functionality remains the same forlegacy
andtype1
transactions. Fortype2
transactionsmaxFeePerGas
is interpreted asgasPrice
andmaxPriorityFeePerGas
is ignored.The way
type1
andtype2
transactions are written/read to/from database differs from the way corresponding operations are performed forlegacy
transactions. In order for their rlp to always remain the same they are stored as following:rlp( type + transactionRLP )
.legacy
transactions are stored just astransactionRLP
.Tests
added new unit tests - send
type1
andtype2
rlps to skaled.and check their receiptsadded new unit tests - call new JSON-RPC methods and verify the response
tested manually by sending
type1
andtype2
transactions usingweb3.py
,web3.js
,ethers.js
andskale.py
manually tested integration with blockscout and different wallets
tested with archive node on devnet
Performance Impact
response for some json-rcp calls may take longer potentially, due to the call to
prices.db