-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/1588 change snapshot hash computation #1787
Merged
DmytroNazarenko
merged 9 commits into
v3.18.0
from
bug/1640-change-snapshot-hash-computation
Jan 18, 2024
Merged
Bug/1588 change snapshot hash computation #1787
DmytroNazarenko
merged 9 commits into
v3.18.0
from
bug/1640-change-snapshot-hash-computation
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
January 17, 2024 20:33
SUGGESTIONS BEFORE MERGE:
|
olehnikolaiev
changed the title
Bug/1640 change snapshot hash computation
Bug/1588 change snapshot hash computation
Jan 17, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1787 +/- ##
===========================================
- Coverage 46.02% 45.68% -0.35%
===========================================
Files 358 358
Lines 51820 51878 +58
===========================================
- Hits 23852 23701 -151
- Misses 27968 28177 +209 |
dimalit
previously approved these changes
Jan 17, 2024
dimalit
previously approved these changes
Jan 18, 2024
kladkogex
approved these changes
Jan 18, 2024
DmytroNazarenko
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1588
do not force leveldb to store all the key-value pairs in OS buffer
instead iterate over the database batch by batch to decrease RAM usage during snapshot hash calculation
tested on devnet: