Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-902 check block number to download snapshot #1784

Merged
merged 7 commits into from
Jan 17, 2024
Merged

IS-902 check block number to download snapshot #1784

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9431fab
IS-902 check block number to download snapshot
olehnikolaiev Jan 12, 2024
b4a849d
Merge branch 'v3.18.0' into bug/IS-902-allow-uploading-only-one-snapshot
olehnikolaiev Jan 16, 2024
aab2420
IS 902 handle wrong snapshot block number request for signatures
olehnikolaiev Jan 16, 2024
53160e7
Merge branch 'bug/IS-902-allow-uploading-only-one-snapshot' of github…
olehnikolaiev Jan 16, 2024
99a645a
fix tests
olehnikolaiev Jan 17, 2024
886c695
fix tests
olehnikolaiev Jan 17, 2024
04298fe
Merge branch 'v3.18.0' into bug/IS-902-allow-uploading-only-one-snapshot
olehnikolaiev Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libweb3jsonrpc/Skale.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ nlohmann::json Skale::impl_skale_getSnapshot( const nlohmann::json& joRequest, C

// TODO check
unsigned blockNumber = joRequest["blockNumber"].get< unsigned >();
if ( blockNumber != m_client.getLatestSnapshotBlockNumer() ) {
joResponse["error"] = "Invalid snapshot block number requested - it might be deleted.";
return joResponse;
}

// exit if too early
if ( currentSnapshotBlockNumber >= 0 ) {
Expand Down Expand Up @@ -366,6 +370,11 @@ Json::Value Skale::skale_getSnapshotSignature( unsigned blockNumber ) {
if ( chainParams.nodeInfo.keyShareName.empty() || chainParams.nodeInfo.sgxServerUrl.empty() )
throw jsonrpc::JsonRpcException( "Snapshot signing is not enabled" );

if ( blockNumber != this->m_client.getLatestSnapshotBlockNumer() ) {
throw jsonrpc::JsonRpcException(
"Invalid snapshot block number requested - it might be deleted." );
}

try {
dev::h256 snapshot_hash = this->m_client.getSnapshotHash( blockNumber );
if ( !snapshot_hash )
Expand Down
Loading