Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1689 microprofile build #1690

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Oct 10, 2023

fixes #1689

fixed build by disabling compiler errors and fixed SIGILL by executing dev::setThreadName("main") earlier in the code

verified locally, skaled starts and mines blocks

@olehnikolaiev olehnikolaiev changed the base branch from develop to v3.18.0 October 10, 2023 10:30
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1690 (c420ff1) into v3.18.0 (f10195c) will decrease coverage by 0.07%.
Report is 3 commits behind head on v3.18.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1690      +/-   ##
===========================================
- Coverage    44.92%   44.86%   -0.07%     
===========================================
  Files          340      340              
  Lines        51251    51251              
===========================================
- Hits         23025    22993      -32     
- Misses       28226    28258      +32     

@olehnikolaiev olehnikolaiev merged commit cff2955 into v3.18.0 Oct 10, 2023
7 of 8 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1689-microprofile-build branch October 10, 2023 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

microprofile build doesn't work
3 participants