Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1658 Fix totalMemory calculation used for garbage collection #1659

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Sep 20, 2023

Total memory calculation in garbage collection loop should not take into account
blockHashes since they are treated separately

To Reproduce
Set cache size to a small value (2000 bytes)
Run the smart contract tests in tests/historic_state

SKALED will hang forever in garbage collection while loop

@kladkogex kladkogex self-assigned this Sep 20, 2023
@kladkogex kladkogex added this to the 2.2 milestone Sep 20, 2023
@kladkogex kladkogex linked an issue Sep 20, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1659 (23702e5) into develop (98f342d) will increase coverage by 0.06%.
Report is 13 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head 23702e5 differs from pull request most recent head f4ff5ab. Consider uploading reports for the commit f4ff5ab to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1659      +/-   ##
===========================================
+ Coverage    44.92%   44.98%   +0.06%     
===========================================
  Files          340      340              
  Lines        51248    51248              
===========================================
+ Hits         23022    23053      +31     
+ Misses       28226    28195      -31     

@kladkogex kladkogex closed this Sep 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@kladkogex kladkogex deleted the 1658-Fix-totalMemory-calculation-used-for-garbage-collection branch October 2, 2023 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix totalMemory calculation used for garbage collection
1 participant