-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental/rocks db support #1187
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiy-skalelabs
requested review from
DimaStebaev,
dimalit,
kladkogex,
olehnikolaiev and
gannakulikova
October 8, 2022 00:24
SUGGESTIONS BEFORE MERGE:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--db=***
command line argument to specify values likerocksdb
/leveldb
/memorydb
, default isleveldb
for backward compatibility--db=rocksdb
command line argument specifiedMemoryDB
renamed toMemoryDB_S
, because newMemoryDB
class is working memory database backend nowSplitDB
class commented/removed because it's not usedDBImp.h
file andnamespace DBImp
were removed because they are no longer neededDBFactory
class and it's used everywhere in skaled to create DB instants of backed type specified by --db=***`