Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate skale-contracts library #555

Merged
merged 19 commits into from
Apr 16, 2024
Merged

Integrate skale-contracts library #555

merged 19 commits into from
Apr 16, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented Mar 26, 2024

Integrate skale-contract into the skale.py
After these changes instead of passing path to an ABI file to a constructor of any class implementing SkaleBase an alias or address of a smart contracts instance must be passed.

@DimaStebaev DimaStebaev linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 83.05085% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.99%. Comparing base (6cdac9f) to head (5683233).

Files Patch % Lines
skale/skale_allocator.py 58.33% 5 Missing ⚠️
skale/contracts/allocator/escrow.py 33.33% 2 Missing ⚠️
skale/utils/helper.py 77.77% 2 Missing ⚠️
skale/skale_base.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #555      +/-   ##
===========================================
- Coverage    91.16%   90.99%   -0.18%     
===========================================
  Files           65       64       -1     
  Lines         2468     2464       -4     
===========================================
- Hits          2250     2242       -8     
- Misses         218      222       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review April 5, 2024 09:51
@DimaStebaev DimaStebaev merged commit af18f01 into develop Apr 16, 2024
6 of 8 checks passed
@DimaStebaev DimaStebaev deleted the skale-contracts branch April 16, 2024 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate skale-contracts
2 participants